Re: [Xen-devel] [PATCH] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 7 Jul 2016, Andrew Cooper wrote:
> On 07/07/16 14:17, Lars Kurth wrote:
> >> On 7 Jul 2016, at 14:14, Julien Grall <julien.grall@xxxxxxx> wrote:
> >>
> >>
> >>
> >> On 07/07/16 13:43, Lars Kurth wrote:
> >>>> On 7 Jul 2016, at 12:28, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> >>>>
> >>>> Also CC Lars.
> >>>>
> >>>> On Mon, Jul 04, 2016 at 12:12:52PM +0100, Julien Grall wrote:
> >>>>> (CC Wei for the release part)
> >>>>>
> >>>>> Hi Dirk,
> >>>>>
> >>>>> On 04/07/16 07:51, Dirk Behme wrote:
> >>>>>> Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> >>>>> Thank you for adding support of a new board in Xen.
> >>>>>
> >>>>> During the last hackathon, we discussed about improving pre-release 
> >>>>> testing
> >>>>> on ARM hardware [1] and helping users to boot Xen on supported board.
> >>>>>
> >>>>> This patch is the first board officially supported since then, so I 
> >>>>> would
> >>>>> like to start applying what was discussed (I will put on a wiki page 
> >>>>> later).
> >>>>> Below the list of things that I would like to see when a new board is 
> >>>>> added:
> >>>>>
> >>>>>   - Create a wiki page to explain the requirements to boot Xen on the 
> >>>>> board
> >>>>> (e.g new firmware if not supported out of box, linux version,...);
> >>>>>   - Add a link to the new page in [2];
> >>>>>   - Add the contact details in [3] of someone who would could test
> >>>>> pre-release and help out users to boot Xen on the board.
> >>>>>
> >>>>> I do not expect the latter point to be time consuming. It is basically
> >>>>> checking if Xen boots before each release and possibly update the
> >>>>> requirements of the board. For the part helping users, it will mostly be
> >>>>> question related to booting Xen on the hardware. Others may not be able 
> >>>>> to
> >>>>> answer because they do not have the board on their desk.
> >>>>>
> >>>> FWIW having some wiki pages, and most importantly contact details, would
> >>>> be a good starting point.
> >>> I did actually create these pages during the Hackathon and sent it out to 
> >>> the list, but they were not populated by anyone. See
> >>> http://wiki.xenproject.org/wiki/Xen_ARM_Manual_Smoke_Test
> >>> http://wiki.xenproject.org/wiki/Xen_ARM_Manual_Smoke_Test/Results
> >>>
> >>>> Can we also have a section in MAINTAINERS for different boards (or a
> >>>> dedicated file?) so that we can easily gather all contact and send
> >>>> emails in a batch when the release is near?
> >>> I am not in principle against this, but a concrete proposal would need to 
> >>> be made. In fact that may be better than using the wiki (given the lack 
> >>> of traction around it)
> >> I think a file in the repository would be more formal than a wiki page.
> >>
> >> However, the MAINTAINERS file may not be the right place because some 
> >> board will not have any specific code/file in Xen (e.g the RCAR-3 only add 
> >> earlyprintk). But we would still want to keep track of them for testing 
> >> purpose and advertising the board supported.
> >>
> >> I was thinking to add a file board under docs/misc/arm/boards.txt with the 
> >> list of board and a contact associated I would add some words about the 
> >> "responsibility" of the contact such as:
> >>   - Testing
> >>   - Answering questions related to the board
> >>
> >> I would also keep the wiki page [1] (+ a link in the file) to log the 
> >> testing result per release.
> >>
> >> Finally, we may want to track whether the board is "supported", 
> >> "obsolete", "untested"...
> >>
> >> I will try to write a concrete proposal.
> > Sounds sensible. Please CC me. You may also want to CC Andy Cooper as he 
> > has been doing something similar for some features
> 
> +10 for something in the docs/ tree.
> 
> It is far easier to keep up to date, and easy to mandate "patches for
> new boards are not accepted without an update to that document".

I agree with Andrew. It is difficult to request a change in the wiki in
order to commit a patch. Better to do everything with git.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel