[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/8] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup



On 7/4/2016 7:16 PM, Jan Beulich wrote:
On 04.07.16 at 18:09, <czuzu@xxxxxxxxxxxxxxx> wrote:
Now that I think about it, that's feasible too. So then, make
arch_vm_event be dynamically allocated as it was, but slightly change
its definition to:

struct arch_vm_event {
       uint32_t emulate_flags;
       struct vm_event_emul_read_data *emul_read_data;
       struct monitor_write_data *write_data;
};

, allocate it when it was previously allocated along emul_read_data and
write_data but don't ever deallocate it entirely, instead only
deallocate  and reallocate selectively (emul_read_data) as needed, correct?
Yes, if that also fits you.

Jan

Heh, within the above scheme I only now realized it would make no sense to have write_data dynamically allocated.
With that settled, thanks for the great feedback.

Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.