Re: [Xen-devel] [PATCH 06/18] arm/altp2m: Add a(p2m) table flushing routines.

[Julien Grall <julien.grall@xxxxxxx>]

On 04/07/16 12:45, Sergej Proskurin wrote:
> +void p2m_flush_altp2m(struct domain *d)
> +{
> +    unsigned int i;
> +
> +    altp2m_lock(d);
> +
> +    for ( i = 0; i < MAX_ALTP2M; i++ )
> +    {
> +        p2m_flush_table(d->arch.altp2m_p2m[i]);
> +        flush_tlb();
I forgot to comment on this line.

Can you explain this call? flush_tlb is flushing TLBs for the current 
VMID only. However, d may not be equal to current when calling from HVM op.
> +        d->arch.altp2m_vttbr[i] = INVALID_MFN;
> +    }
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel