Re: [Xen-devel] [PATCH v2 2/7] build: convert crash_debug to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.16 at 05:10, <cardoe@xxxxxxxxxx> wrote:
> On 5/3/16 9:43 AM, Jan Beulich wrote:
>>>>> On 03.05.16 at 16:29, <cardoe@xxxxxxxxxx> wrote:
>>> Convert the crash_debug option to Kconfig as CONFIG_CRASH_DEBUG. This
>>> was previously togglable on the command line so this adds a message for
>>> users enabling it from the command line to tell them to enable it from
>>> make menuconfig.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>>> ---
>>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>>> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> 
>> I think the Cc list should be quite a bit wider here.
>> 
>>> --- a/xen/Kconfig.debug
>>> +++ b/xen/Kconfig.debug
>>> @@ -5,3 +5,14 @@ menuconfig DEBUG
>>>       If you want to debug Xen say Y and select any additional debugging
>>>       support options. Enabling this option is intended for development
>>>       purposes only, and not for production use.
>>> +
>>> +if DEBUG
>> 
>> Didn't we agree on "DEBUG || EXPERT" at the hackathon? With tha
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
> 
> Well this will actually fundamentally change the patch. Because the
> DEBUG flag is a menuconfig so I can't just do "DEBUG || EXPERT".

I don't understand. I didn't say to change the config option, all I
asked for was to change the conditional. And I don't see why that
can't become "if DEBUG || EXPERT".

> I guess
> the concern here is that I tied DEBUG to #undef NDEBUG? I can disconnect
> that and make the operation of NDEBUG its own thing.

No, that's not the concern. The concern is that the sub-options
should be separately controllable even when DEBUG is off.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel