Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.16 at 04:22, <cardoe@xxxxxxxxxx> wrote:
> On 5/3/16 10:18 AM, Jan Beulich wrote:
>>>>> On 03.05.16 at 17:10, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 03/05/16 16:05, Jan Beulich wrote:
>>>>>>> On 03.05.16 at 16:29, <cardoe@xxxxxxxxxx> wrote:
>>>>> --- /dev/null
>>>>> +++ b/xen/Kconfig.debug
>>>>> @@ -0,0 +1,7 @@
>>>>> +
>>>>> +menuconfig DEBUG
>>>>> + bool "Debugging Options"
>>>> One more thing: In the unstable branch this should really default to
>>>> y, and the release check list should be adjusted to say that this
>>>> default needs to be dropped (or inverted) while preparing a release.
>>>>
>>>> And obviously the "debug=" also needs to go away from ./Config.mk.
>>>
>>> Things other than Xen make use of debug= in the root Config.mk. 
>>> Valgrind client requests for example in libxc.
>>>
>>> That option can't be moved without providing an alternative.
>> 
>> Why can't it be moved into tools/ if that's where it is still of interest?
> 
> You could argue it could then move into the autoconf script which would
> make the knobs more consistent for each part of the tree. The tools/
> bits always as autoconf and the xen/ bits as Kconfig.

I agree, but perhaps as a separate step.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel