Re: [Xen-devel] [PATCH v8.1 19/27] xsplice: Add support for alternatives

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >+            return -EINVAL;
> >+        }
> >+
> >+        start = sec->load_addr;
> >+        end = sec->load_addr + sec->sec->sh_size;
> >+
> >+        for ( a = start; a < end; a++ )
> >+        {
> >+            unsigned long instr = (unsigned long)(&a->instr_offset + 
> >a->instr_offset);
> >+            unsigned long replacement = (unsigned long)(&a->repl_offset + 
> >a->repl_offset);
> >+
> >+            if ( (instr < region->start && instr >= region->end) ||
> >+                 (replacement < region->start && replacement >= 
> >region->end) )
> >+            {
> >+                dprintk(XENLOG_ERR, XSPLICE "%s Alt patching outside 
> >payload: 0x%lx!\n",
> 
> %#lx please

To drop on the casting I changed the instr and replacement to be 'const void *'
(and also made region->start, and end be const void * as well) so this instead
of being %#lx ended up being %p.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel