[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] pygrub: Ignore GRUB2 if statements

Ross Lagerwall writes ("[PATCH 1/2] pygrub: Ignore GRUB2 if statements"):
> SLES 12's default GRUB config has the following code before any entries:
> if [ -n "$extra_cmdline" ]; then
>   submenu "Bootable snapshot #$snapshot_num" {
>     menuentry "If OK, run 'snapper rollback' and reboot." { true; }
>   }
> fi
> This prevents pygrub from booting using the default entry. Since I'm not
> aware of any distro GRUB config which puts useful entries within
> conditionals, ignore them.

I think this has a risk of breaking things, doesn't it ?  I mean,
existing setups might contain `if's and the relevant parts would no
longer be processed.

So I think this isn't a backport candidate.  And really I would like
an alternative, less risky fix, which would be a backport candidate.
Can you think of an alternative approach ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.