Re: [Xen-devel] [PATCH v2 1/2] xen: move perform_gunzip to common

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.09.15 at 15:56, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 13 Aug 2015, Jan Beulich wrote:
>> >>> On 13.08.15 at 13:21, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> > --- a/xen/common/Makefile
>> > +++ b/xen/common/Makefile
>> > @@ -55,6 +55,7 @@ obj-y += vmap.o
>> >  obj-y += vsprintf.o
>> >  obj-y += wait.o
>> >  obj-y += xmalloc_tlsf.o
>> > +obj-y += gunzip.o
>> >  
>> >  obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma unlzo 
>> > unlz4 earlycpio,$(n).init.o)
>> 
>> Isn't the code you add in gunzip.c all __init / __initdata (or could at least
>> be)? If so, this should become obj-bin-y += gunzip.o just like is being
>> done for all the other decompressors.
> 
> OK, I'll make the change

Just for the avoidance of doubt or future confusion: I didn't spell
this out correctly, it ought to be "obj-bin-y += gunzip.init.o".

>> > +#define memzero(s, n)   memset((s), 0, (n))
>> 
>> I understand that you're mostly moving code, but I'd appreciate if
>> you did some formatting adjustments along the way (like removing
>> the superfluous parentheses here...
> 
> I prefer to keep code movement as code movement -- much easier to bisect
> or spot regressions. If you have any changes that you really require on
> top of the movement, I could carry them on a separate patch on top of
> this.

Well, okay then (albeit I'm not really happy about the code that
way remaining as crappy as it used to be).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel