[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC



>>> On 27.08.15 at 17:27, <david.vrabel@xxxxxxxxxx> wrote:
> On 27/08/15 15:47, Jonathan Creekmore wrote:
>> @@ -125,6 +126,22 @@ do {                                                \
>>          cpu_relax();                                            \
>>      }                                                           \
>>  } while (0)
>> +#else
>> +#define IOMMU_WAIT_OP(iommu, offset, op, cond, sts) \
>> +do {                                                \
>> +    s_time_t start_time = NOW();                    \
>> +    while (1) {                                     \
>> +        sts = op(iommu->reg, offset);               \
>> +        if ( cond )                                 \
>> +            break;                                  \
>> +        if ( NOW() > start_time + DMAR_OPERATION_TIMEOUT ) {    \
>> +      panic("%s:%d:%s: DMAR hardware is malfunctional",     \
>> +            __FILE__, __LINE__, __func__);                  \
>> +        }                                                       \
>> +        cpu_relax();                                            \
>> +    }                                                           \
>> +} while (0)
>> +#endif
> 
> This is particular might be best done by making kexecing a static const
> variable equal to 0 in the !KEXEC case.

Or even a #define (unless there's some use somewhere preventing
that).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.