Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.15 at 17:22, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 27/08/15 15:47, Jonathan Creekmore wrote:
>> @@ -812,7 +816,11 @@ ENTRY(hypercall_args_table)
>>          .byte 2 /* do_hvm_op            */
>>          .byte 1 /* do_sysctl            */  /* 35 */
>>          .byte 1 /* do_domctl            */
>> +#ifdef CONFIG_KEXEC
>>          .byte 2 /* do_kexec             */
>> +#else
>> +        .byte 0 /* do_ni_hypercall      */
>> +#endif
> 
> These changes will corrupt guest registers in debug builds.

It's quite the other way around: Other than now (where two
registers get clobbered), no registers would be clobbered
anymore. Of course that's not to say the argument count
tables shouldn't be left alone.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel