Re: [Xen-devel] [PATCH v5 27/28] libxc: switch xc_dom_elfloader to be used with HVMlite domains

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Aug 21, 2015 at 06:53:40PM +0200, Roger Pau Monne wrote:
> Allow xc_dom_elfloader to report a guest type as hvm-3.0-x86_32 if it's
> running inside of a HVM container and has the PHYS32_ENTRY elfnote set.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> Only xc_dom_elfloader has been switched to support HVMlite, other loaders
> should also be switched once we have a HVMlite compatible kernel that uses
> them.
> ---
> Changes since v4:
>  - Add Andrew Cooper Reviewed-by.
> ---
>  tools/libxc/xc_dom_elfloader.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/libxc/xc_dom_elfloader.c b/tools/libxc/xc_dom_elfloader.c
> index 66ea9d6..f3a0ed7 100644
> --- a/tools/libxc/xc_dom_elfloader.c
> +++ b/tools/libxc/xc_dom_elfloader.c
> @@ -56,6 +56,10 @@ static char *xc_dom_guest_type(struct xc_dom_image *dom,
>  {
>      uint64_t machine = elf_uval(elf, elf->ehdr, e_machine);
>  
> +    if ( dom->container_type == XC_DOM_HVM_CONTAINER &&
> +         dom->parms.phys_entry != UNSET_ADDR )
> +        return "hvm-3.0-x86_32";
> +
>      switch ( machine )
>      {
>      case EM_386:
> -- 
> 1.9.5 (Apple Git-50.3)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel