Re: [Xen-devel] [RFC 2/2] xen/public: grant-table: Specificy the size of the grant

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.08.15 at 12:00, <julien.grall@xxxxxxxxxx> wrote:

> 
> On 12/08/2015 08:21, Jan Beulich wrote:
>> This paragraph should get "on ARM" added somewhere. There is no
>> inherent requirement for such a restriction on another architecture
>> Xen might get ported to; the only restriction of the current interface
>> is that it can't support page sizes from 64k up. On an architecture
>> e.g. not supporting other than 8k pages things would still be fine,
>> yet the comment above would then be wrong.
>>
>> An alternative might be to say "... is always the smallest
>> architecturally supported page size (e.g. 4k on x86 and ARM)
>> irrespective of ...".
> 
> While this is true today, I don't see anything that would prevent a new 
> architecture to respect this.

I don't think I get what you're trying to say here.

> What about replacing 4KB by "Xen Page size" and define this size per 
> architecture in arch-*.h?

That looks okay to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel