Re: [Xen-devel] [PATCH 1/2] ACPI/table: Always count matched and successfully parsed entries

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2015/8/12 16:51, Jan Beulich wrote:
>>>> On 04.08.15 at 06:19, <zhaoshenglong@xxxxxxxxxx> wrote:
>> From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> 
> This is not true. All you did is port a Linux change.
> 
Will change this.

>> acpi_parse_entries() allows to traverse all available table entries (aka
>> subtables) by passing max_entries parameter equal to 0, but since its count
>> variable is only incremented if max_entries is not 0, the function always
>> returns 0 for max_entries equal to 0.  It would be more useful if it returned
>> the number of entries matched instead, so make it increment count in that
>> case too.
>>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
>> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> 
> Please mention the respective Linux commit. Without that I would
> complain that "more useful" is too fuzzy (as in not making clear to
> whom and why).
> 
Ok, will add it. Thanks.

-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel