Re: [Xen-devel] [PATCH 2/2] ACPI/table: Make acpi_table_init return meaningful value

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.15 at 06:19, <zhaoshenglong@xxxxxxxxxx> wrote:
> From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> 
> If ACPI fails to initialize tables, it should return one meaningful
> value to tell the caller to diable acpi.
> 
> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> ---
>  xen/drivers/acpi/tables.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
> index 822689e..1594e3b 100644
> --- a/xen/drivers/acpi/tables.c
> +++ b/xen/drivers/acpi/tables.c
> @@ -330,7 +330,11 @@ static void __init check_multiple_madt(void)
>  
>  int __init acpi_table_init(void)
>  {
> -     acpi_initialize_tables(NULL, ACPI_MAX_TABLES, 0);
> +     acpi_status status;
> +
> +     status = acpi_initialize_tables(NULL, ACPI_MAX_TABLES, 0);
> +     if (ACPI_FAILURE(status))
> +             return -EINVAL;

While this makes it look like you didn't directly clone Linux commit
9e3a9d1ed8, it still very much resembles that one (with 95df812dbd
on top) and hence I'd prefer if you said so (and used the same titles
and descriptions) to ease identifying their origin.

Jan

>       check_multiple_madt();
>       return 0;
>  }
> -- 
> 2.0.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel