Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2015/7/21 19:11, Ian Jackson wrote:
> Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts 
> with RDM"):
> > I would add this check at the beginning of this function:
> >
> > assert(!d_config->num_rdms && !d_config->rdms).
> As Ian Campbell and I have explained, that is not OK.
>
> The caller may choose to pass both some rdms and strategy=host.
If you're talking to create the domain twice I think this should be 
reasonable,
if (d_config->num_rdms) return 0;

Because RDMs are always associated to the platform so we should keep the 
same array. I mean same configuration shouldn't change this point.
Thanks
Tiejun

> The most obvious case is something like the following code
>
>    libxl_domain_config cfg;
>    cfg.stuff = blah;
>    cfg.rdm.strategy = HOST;
>
>    libxl_domain_create_new(&cfg, &domid);
>    libxl_domain_destroy(domid);
>    libxl_domain_create_new(&cfg, &domid);
>
> which must work (and the second domain should have identical
> configuration to the first).
>
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel