Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

> The domain destroy would not change cfg at all.
Okay.

> > If not, I should double check this duplication so what about a return in
> > the case of duplicating one entry?
> What I am looking for is a *decision* about what the right behaviour
> is, backed up by a *rationale*.
>
> The most obvious answer to me would be that if an rdms array is
> specified, the strategy should be ignored.  That is how the automatic
> numa placement API works.
I'm not familiar with this.

Do you mean this?

    if (d_config->num_rdms)
        strategy = LIBXL_RDM_RESERVE_STRATEGY_IGNORE;

But except this global strategy, we also have per-device setting so 
maybe something like this?
    if (d_config->num_rdms)
        return 0;

> But another answer would be to take the union of the specified
> regions.  That would be more complicated, because the union would have
> to be computed.
>
> >               if (d_config->rdms[i].start == rdm_start)
> >                   return;
> That doesn't, of course, compute the union.
Sorry I don't understand what the "take the union of the specified 
regions" is here.
Thanks
Tiejun


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel