[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c



Il 09/06/2015 12:54, Fabio Fantoni ha scritto:
Il 09/06/2015 09:02, Olaf Hering ha scritto:
On Mon, Jun 08, Fabio Fantoni wrote:

I saw that config/Paths.mk contains:
XEN_DUMP_DIR             := /var/lib/xen/dump

But build fails with:
xl_cmdimpl.c: In function Ãhandle_domain_deathÃ:
xl_cmdimpl.c:2330:33: error: ÃXEN_DUMP_DIRÃ undeclared (first use in this
function)
xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
once for each function it appears in
xl_cmdimpl.c:2330:46: error: expected Ã)Ã before string constant
With a fast look in code I not found the right cause.
The logic in the Makefile is supposed to regenerate _paths.h if anything
within that file changes. Appearently that logic does not work properly.

As suggested a 'make clean' or 'rm tools/*/_*.h' should work around such
bug.

Olaf

'make clean' or 'rm tools/*/_*.h' as workaround didn't works, problem still happen.

I already use git reset --hard and git git clean -f -d -x before any test that clean all except other git repos (seabios, ovmf and qemu).

I missed to tell I use also a change I did for workaround in Config.mk:
PYTHON_PREFIX_ARG ?= --prefix="$(prefix)" to PYTHON_PREFIX_ARG ?=

Probably it in combination with one or more ./configure options that have a regression.

I'm testing with this: https://github.com/Fantu/Xen/commits/rebase/m2r-staging and was working until https://github.com/Fantu/Xen/commits/rebase/m2r-next Is simply a rebase and only the first patch had a conflict for this commit: 7f5f57b466b026d19cacfe7fc5771895d05a053b

Problem found, I not saw other Config.mk changes during conflict on rebase, I'm stupid, sorry.


The regression should be between upstream commit f48218fd2d35e274ef58caee889aecd6610c8cb6 and ecdae1cfaa7f6123decaa1b9d7205c3ff726b941


Without problem tools/libxl/_paths.h is correctly generated:
#define sbindir "/usr/sbin"
#define bindir "/usr/bin"
#define LIBEXEC "/usr/lib/xen"
#define LIBEXEC_BIN "/usr/lib/xen/bin"
#define libdir "/usr/lib"
#define SHAREDIR "/usr/share"
#define XENFIRMWAREDIR "/usr/lib/xen/boot"
#define XEN_CONFIG_DIR "/etc/xen"
#define XEN_SCRIPT_DIR "/etc/xen/scripts"
#define XEN_LOCK_DIR "/var/lock"
#define XEN_RUN_DIR "/var/run/xen"
#define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
#define XEN_DUMP_DIR "/var/lib/xen/dump"

With the problem instead:
#define SBINDIR ""
#define BINDIR ""
#define LIBEXEC "/usr/lib/xen"
#define LIBEXEC_BIN "/usr/lib/xen/bin"
#define LIBDIR ""
#define SHAREDIR "/usr/share"
#define XENFIRMWAREDIR "/usr/lib/xen/boot"
#define XEN_CONFIG_DIR "/etc/xen"
#define XEN_SCRIPT_DIR "/etc/xen/scripts"
#define XEN_LOCK_DIR "/var/lock"
#define XEN_RUN_DIR "/var/run/xen"
#define XEN_PAGING_DIR "/var/lib/xen/xenpaging"

I'm still trying various combinations but I have a problem to found the exactly parameters that cause the problem, some restult are strange...I'm going crazy :(

During testing I had also this:
ovmf.c: In function Ãovmf_loadÃ:
ovmf.c:100:21: error: Ãovmfà undeclared (first use in this function)
ovmf.c:100:21: note: each undeclared identifier is reported only once for each function it appears in
ovmf.c: At top level:
ovmf.c:154:14: error: Ãovmfà undeclared here (not in a function)
Probably because I tried before with build ovmf and after with prebuild from system that cause an inexpected case

This and probably another (that I not remember exactly) are the only upstream minor problems caused by rare unexpected case.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.