Re: [Xen-devel] [RFC 03/22] xen/arm: gic-v3: Fix the distributor region to 64kB

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/06/15 14:29, Ian Campbell wrote:
> On Fri, 2015-06-05 at 13:56 +0100, Julien Grall wrote:
>> On 05/06/15 13:14, Ian Campbell wrote:
>>> On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote:
>>>> On GICv3, the default size of the distributor region is 64kB. This
>>>> region can be extended
>>>
>>> But never shrunk, correct? Would a sanity check during parsing be
>>> worthwhile?
> 
>> Yes. See 5.3 in PRD03-GENC-010745 24.0. I can add a reference to it.
> 
> Good, thanks.
> 
>> Well, we trust the device tree value in many place in Xen. If the DT
>> provided by the platform is wrong, Xen won't be the only software in
>> trouble.
> 
> We do warn about other similar things though, as a helpful hint to our
> users. (dodgy timer interrupt stuff springs to mind)

We don't do any check size in GIC drivers. If we add this one, I would
prefer to add all the others one too. But in a separate driver.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel