Re: [Xen-devel] [RFC 03/22] xen/arm: gic-v3: Fix the distributor region to 64kB

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-05-08 at 14:29 +0100, Julien Grall wrote:
> On GICv3, the default size of the distributor region is 64kB. This
> region can be extended

But never shrunk, correct? Would a sanity check during parsing be
worthwhile?

>  to provide an implementation defined set of
> pages containing additional aliases for MSI. Although, the GICv3 driver
> only access to register within the default distributor region.

"only accesses registers within".

> 
> Futhermore, our vGIC driver implementation don't support the extended

"Furthermore" and "doesn't support"

> distributor. Therefore there is no reason to claim it to DOM0.

I think I would say "expose" or "map" rather than claim?

> Finally drop the field dbase_size which is not useful anymore.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>


With the typoes fixed:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel