Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

[Tamas Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Mar 12, 2015 at 1:13 PM, Tim Deegan <tim@xxxxxxx> wrote:

At 01:11 +0100 on 18 Feb (1424218291), Tamas K Lengyel wrote:
> +struct mem_event_mem_access {
>Â Â Â uint64_t gfn;
>Â Â Â uint64_t offset;
> -Â Â uint64_t gla; /* if gla_valid */
> +Â Â uint64_t gla;Â Â/* if flags has MEM_ACCESS_GLA_VALID set */
> +Â Â uint32_t flags; /* MEM_ACCESS_* */
> +Â Â uint32_t _pad;
> +};
> +
> +struct mem_event_mov_to_cr {
> +Â Â uint64_t new_value;
> +Â Â uint64_t old_value;
> +};
> +
> +struct mem_event_debug {
> +Â Â uint64_t gfn;
> +};
>
> +struct mem_event_mov_to_msr {
> +Â Â uint64_t msr;
> +Â Â uint64_t value;
> +};
> +
> +#define MEM_PAGING_DROP_PAGEÂ Â Â Â(1 << 0)
> +#define MEM_PAGING_EVICT_FAILÂ Â Â (1 << 1)
> +
> +struct mem_event_paging {
> +Â Â uint64_t gfn;
>Â Â Â uint32_t p2mt;
> +Â Â uint32_t flags;
> +};
> +
> +struct mem_event_sharing {
> +Â Â uint64_t gfn;
> +Â Â uint32_t p2mt;
> +};

I see you have padded struct mem_event_mem_access to an 8-byte
boundary but not this -- given the union I suppose it makes no
difference but it woud be consistent to add padding here too.

Ack, will do!

Â

In any case,

Acked-by: Tim Deegan <tim@xxxxxxx>

Tim.

Thanks,

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel