Re: [Xen-devel] [PATCH V6 01/13] xen/mem_event: Cleanup of mem_event structures

[Tim Deegan <tim@xxxxxxx>]

At 01:11 +0100 on 18 Feb (1424218291), Tamas K Lengyel wrote:
> +struct mem_event_mem_access {
>      uint64_t gfn;
>      uint64_t offset;
> -    uint64_t gla; /* if gla_valid */
> +    uint64_t gla;   /* if flags has MEM_ACCESS_GLA_VALID set */
> +    uint32_t flags; /* MEM_ACCESS_* */
> +    uint32_t _pad;
> +};
> +
> +struct mem_event_mov_to_cr {
> +    uint64_t new_value;
> +    uint64_t old_value;
> +};
> +
> +struct mem_event_debug {
> +    uint64_t gfn;
> +};
>  
> +struct mem_event_mov_to_msr {
> +    uint64_t msr;
> +    uint64_t value;
> +};
> +
> +#define MEM_PAGING_DROP_PAGE       (1 << 0)
> +#define MEM_PAGING_EVICT_FAIL      (1 << 1)
> +
> +struct mem_event_paging {
> +    uint64_t gfn;
>      uint32_t p2mt;
> +    uint32_t flags;
> +};
> +
> +struct mem_event_sharing {
> +    uint64_t gfn;
> +    uint32_t p2mt;
> +};

I see you have padded struct mem_event_mem_access to an 8-byte
boundary but not this -- given the union I suppose it makes no
difference but it woud be consistent to add padding here too.

In any case,

Acked-by: Tim Deegan <tim@xxxxxxx>

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel