Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 29/01/15 10:29, Stefano Stabellini wrote:
>>> -        seg = domctl->u.assign_device.machine_sbdf >> 16;
>>> -        bus = (domctl->u.assign_device.machine_sbdf >> 8) & 0xff;
>>> -        devfn = domctl->u.assign_device.machine_sbdf & 0xff;
>>> +        seg = machine_sbdf >> 16;
>>> +        bus = (machine_sbdf >> 8) & 0xff;
>>> +        devfn = machine_sbdf & 0xff;
>>
>> If you fiddle with these, please make them use at least PCI_BUS()
>> and PCI_DEVFN2() (we don't have a matching macro for retrieving
>> the segment).
> 
> Maybe we should?

I could add one.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel