Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.01.15 at 11:29, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Tue, 20 Jan 2015, Jan Beulich wrote:
>> >>> On 13.01.15 at 15:25, <julien.grall@xxxxxxxxxx> wrote:
>> > -        seg = domctl->u.assign_device.machine_sbdf >> 16;
>> > -        bus = (domctl->u.assign_device.machine_sbdf >> 8) & 0xff;
>> > -        devfn = domctl->u.assign_device.machine_sbdf & 0xff;
>> > +        seg = machine_sbdf >> 16;
>> > +        bus = (machine_sbdf >> 8) & 0xff;
>> > +        devfn = machine_sbdf & 0xff;
>> 
>> If you fiddle with these, please make them use at least PCI_BUS()
>> and PCI_DEVFN2() (we don't have a matching macro for retrieving
>> the segment).
> 
> Maybe we should?

Maybe, but it would be of pretty limited use, as generally we don't
pass around SBDFs, but (segment, BDF) pairs, or (segment, bus,
devfn) triplets, or all four values separately.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel