Re: [Xen-devel] [PATCH] libxl_set_memory_target: only remove videoram from absolute targets

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 28 Jan 2015, Ian Campbell wrote:
> On Wed, 2015-01-28 at 14:24 +0000, Stefano Stabellini wrote:
> > On Wed, 28 Jan 2015, Ian Campbell wrote:
> > > On Mon, 2015-01-26 at 16:47 +0000, Stefano Stabellini wrote:
> > > > If the new target is relative to the current target, do not remove
> > > > videoram again: it has already been removed from the current target.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > 
> > > How does this relate to "libxl_set_memory_target: retain the same maxmem
> > > offset on top of the current target"? Doesn't that also achieve the same
> > > aim, since maxmem accounts for vram but target doesn't?
> > 
> > The two patches are different: this one affects the memory target while
> > the other one affects maxmem. The only relationship is that this issue
> > was found out by looking at the other patch.
> 
> Not even a textual relationship? (i.e. one needs to go first to avoid
> conflicts)

Yep, there is a textual relationship. Sorry I failed to mention it.

This one needs to go first.


> > This patch didn't make it into 4.5 because although it is a bug fix, it
> > doesn't fix a regression compared to 4.4.
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel