[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/many: xfree() can tolerate NULL pointers

>>> On 19.01.15 at 12:47, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Ian Campbell writes ("Re: [PATCH] xen/many: xfree() can tolerate NULL 
> pointers"):
>> On Mon, 2015-01-19 at 11:12 +0000, Andrew Cooper wrote:
>> > On 19/01/15 10:54, Ian Campbell wrote:
>> > > Anyway, could you include the spatch in the commit log, for completeness
>> > > and for future cargo culting ;-) (unless it's huge, I guess)
>> > 
>> > It was tiny, but sadly scummed to a `git clean`.  I can't even recall
>> > which of the many kfree() variants I ended up modifying (s/k/x/),
>> No worries, next time ;-)
> Umm, further to my last mail, we (the Free Software world in general)
> should treat this the same way we would any other case where the
> source code has been genuinely lost.  We start editing the output
> file, and treat the results as the new source code.
> (Something can only be the preferred form for modification if it
> actually exists.)

So is this an active NAK to the patch then? Afaic the patch
description doesn't even mention the origin being a spatch, and
hence the change by itself seems fine to me, and consistent with
its description - it could easily have been the result of human
auditing of the code.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.