[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/many: xfree() can tolerate NULL pointers

On Mon, 2015-01-19 at 10:42 +0000, Andrew Cooper wrote:
> Replace instances of "if ( p ) xfree(p)" with just "xfree(p)"
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> This was from some experimentation with semantic patches.  'spatch' can't
> currently parse some of our macros (e.g. XEN_GUEST_HANDLE()), which cases it
> to skip large numbers of functions in the codebase

How annoying! (and surprising)

Anyway, could you include the spatch in the commit log, for completeness
and for future cargo culting ;-) (unless it's huge, I guess)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.