Re: [Xen-devel] [PATCH] x86/viridian: Do not leak page refs and mappings if the host tsc is unstable.

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: 14 January 2015 14:33
> To: Xen-devel
> Cc: Andrew Cooper; Keir (Xen.org); Jan Beulich; Paul Durrant; Xen Coverity
> Team
> Subject: [PATCH] x86/viridian: Do not leak page refs and mappings if the host
> tsc is unstable.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Coverity-ID: 1264360
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Paul Durrant <paul.durrant@xxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> CC: Xen Coverity Team <coverity@xxxxxxx>
> ---
>  xen/arch/x86/hvm/viridian.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c
> index cb689f6..1e5a570 100644
> --- a/xen/arch/x86/hvm/viridian.c
> +++ b/xen/arch/x86/hvm/viridian.c
> @@ -287,7 +287,7 @@ static void update_reference_tsc(struct domain *d,
> bool_t initialize)
> 
>          printk(XENLOG_G_INFO "d%d: VIRIDIAN REFERENCE_TSC:
> invalidated\n",
>                 d->domain_id);
> -        return;
> +        goto out;
>      }
> 
>      /*
> @@ -306,6 +306,7 @@ static void update_reference_tsc(struct domain *d,
> bool_t initialize)
>           p->TscSequence == 0 ) /* Avoid both 'invalid' values */
>          p->TscSequence = 1;
> 
> + out:
>      unmap_domain_page(p);
> 
>      put_page_and_type(page);
> --
> 1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel