Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Julien Grall writes ("Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 
for domU"):
> On 11/18/2014 03:10 PM, Ian Jackson wrote:
> > Empty structs are a gcc extension (`(gcc-4.4) Empty Structures').  I
> > would be very surprised if clang didn't support them too.
> 
> AFAIK, clang doesn't complain about empty structures.

Right.

> > AIUI our policy, gcc extensions are fine except in the Xen public
> > headers.
> 
> We have at least 2 "empty" structure on the ARM public header.

That ought to be fixed, in case anyone ever wants to build ARM guests
with Norcroft C or something.

Does the size of these structs matter ?

> Would something like below be better?
> 
> struct
> {
>   int dummy:1
> };

I don't see why you wouldn't just do
   struct blah { char dummy; };
or even int dummy;

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel