Re: [Xen-devel] [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 10/31/2014 09:02 AM, Jan Beulich wrote:
>>>> On 30.10.14 at 19:51, <julien.grall@xxxxxxxxxx> wrote:
> The naming suggests that the #if really should be around just the
> gic_version field (with a dummy field in the #else case to be C89
> compatible, e.g. a zero width unnamed bitfield) and the
> corresponding #define-s above, ...

Not really related to this patch... but the way to improve it (via
extending createdomain).

I need to create an empty structure. Is the dummy field really needed?
If so, did you meant?

struct
{
   int :0;
}

The C spec declare this kind of structure as undefined. Would an empty
structure and used it be better?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel