Re: [Xen-devel] [for-xen-4.5 v9 2/2] dpci: Replace tasklet with an softirq (v12)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.11.14 at 22:02, <konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Nov 04, 2014 at 10:37:29AM +0000, Jan Beulich wrote:
>> >>> On 03.11.14 at 20:14, <konrad.wilk@xxxxxxxxxx> wrote:
>> > +/*
>> > + * Should only be called from hvm_do_IRQ_dpci. We use the
>> 
>> This statement together with the comment in pt_pirq_softirq_active()
>> is at least confusing: If the function is to be called in only one place,
>> there shouldn't be a second place where its use is being suggested.
>> Plus, a function with such required limited use would very likely better
>> not be a separate function at all.
> 
> Could you explain your rationale for it please?

I explained the why in what is still being quoted above.

> I am of course OK changing it, but when reading this patch and having most 
> of the functions that deal with the new code in one place - makes it easier
> to read.

Some pieces of code are necessarily scattered around, so one more
wouldn't be a big deal. But I see you re-worded that comment now,
and with that I don't mind the function remaining where it is.

Hence
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But please re-send properly paired with patch 1/2, to avoid mixing
up versions when committing (it's already confusing that this one
says v9 and v12 in the subject, while the patch history is at v13).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel