Re: [Xen-devel] [PATCH v3 2/2] xen/dt: Allow only IRQ translation that are mapped to main GIC

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 16/07/14 15:34, Ian Campbell wrote:
> On Wed, 2014-07-16 at 15:28 +0100, Julien Grall wrote:
> > > > -    /* TODO: Retrieve the right irq_xlate. This is only work for the gic */
> > > > +    if ( raw->controller != dt_interrupt_controller )
> > > > +        return -EINVAL;
> > > >
> > > > +    /* TODO: Retrieve the right irq_xlate. This is only work for the gic */
> > > "This only works for ...".
> > >
> > > Do you mean it to say "primary gic"? In which case I think it was in the
> > > correct location before (i.e. before the check which enforced that).
> > Which location are you talking about? The one in map_device?
> I meant the place from where it is removed by this patch. I was trying
> to say that the correct form would be (modulo the long line):
>
>          /* TODO: Retrieve the right irq_xlate. This only works for the primary 
> gic */
>          if ( raw->controller != dt_interrupt_controller )
>              return -EINVAL;
>
>          return dt_...xlat(...)
>
> i.e. the comment belongs with the check.
Oh ok. I will it before the check.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel