Re: [Xen-devel] [PATCH v3 1/2] xen/arm: Divide GIC initialization in 2 parts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-09 at 14:23 +0100, Julien Grall wrote:
> Currently the function to translate IRQ from the device tree is set
> unconditionally  to be able to be able to retrieve serial/timer IRQ before the
> GIC has been initialized.
> 
> It assumes that the xlate function won't never changed. We may also need to

"won't ever change".

> @@ -560,8 +561,11 @@ static hw_irq_controller gicv2_guest_irq_type = {
>      .set_affinity = gicv2_irq_set_affinity,
>  };
>  
> +static int __init gicv2_init(void);

I think you can reorder things to
        gic_init() { }
        ops
        gic_preinit()
to avoid the forward declaration.

> @@ -261,11 +265,15 @@ struct gic_info {
>      uint8_t nr_lrs;
>      /* Maintenance irq number */
>      unsigned int maintenance_irq;
> +    /* Pointer to the device tree node representing the interrupt controller 
> */
> +    const struct dt_device_node *node;

You added this to both struct gic_info and gicv2_info?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel