Re: [Xen-devel] [PATCH v3 4/6] xen/PMU: Describe vendor-specific PMU registers

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/04/2014 06:41 AM, David Vrabel wrote:
> On 03/07/14 20:14, Boris Ostrovsky wrote:
> > AMD and Intel PMU register initialization and helpers that determine whether a
> > register belongs to PMU.
> >
> > This and some of subsequent PMU emulation code is somewhat similar to Xen's PMU
> > implementation.
> I trust that the hardware bit are correct.
>
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>
> Although I wonder if a lookup table might be better than the chain of ifs.
I'll see if I can do that (while keeping code readable).

-boris

(Thanks for strim pointer, I didn't know we had one)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel