[Xen-devel] [PATCH v2] libxl: fix cirrus vga video memory setting with upstream qemu

[Fabio Fantoni <fabio.fantoni@xxxxxxx>]

Upstream qemu cirrus vga videoram setting parameter is wrong.
Under this condition qemu silently ignores this setting and
doesn't show any errors.

This patch use vgamem_mb property that was added in qemu 1.3,
in which was introduced cirrus vga videoram modification
(previous missed)

Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
Reviewed-by: Don Slutz <dslutz@xxxxxxxxxxx>

---

Changes in v2:
Improved commit message

Note:
- when this patch will be accepted upstream should be
  backported also on xen 4.4
---
 tools/libxl/libxl_dm.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 8abed7b..90f19b7 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -508,9 +508,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc 
*gc,
             flexarray_append_pair(dm_args, "-device", "VGA");
             break;
         case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
-            flexarray_append_pair(dm_args, "-device", "cirrus-vga");
-            flexarray_append_pair(dm_args, "-global",
-                GCSPRINTF("vga.vram_size_mb=%d",
+            flexarray_append_pair(dm_args, "-device",
+                GCSPRINTF("cirrus-vga,vgamem_mb=%d",
                 libxl__sizekb_to_mb(b_info->video_memkb)));
             break;
         case LIBXL_VGA_INTERFACE_TYPE_NONE:
-- 
1.7.9.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel