Re: [Xen-devel] [PATCH 01/12] Config.mk: move directory list into BUILD_MAKE_VARS

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 12:57 +0200, Olaf Hering wrote:
> On Fri, May 02, Ian Campbell wrote:
> 
> > Probably doesn't matter for this particular patch, but I fear it might
> > for the upcoming changes you refer to. Did you test a stubdom build with
> > them?
> 
> Yes.
> 
> 
> > >   $(foreach var,                                                      \
> > > -           SBINDIR BINDIR LIBEXEC LIBDIR SHAREDIR PRIVATE_BINDIR     \
> > > -           XENFIRMWAREDIR XEN_CONFIG_DIR XEN_SCRIPT_DIR XEN_LOCK_DIR \
> > > -           XEN_RUN_DIR XEN_PAGING_DIR,                               \
> > > +           $(BUILD_MAKE_VARS),                                       \
> > 
> > I think this can now go on the same line as the foreach. Possibly the
> > whole thing might fit on one line now too?
> 
> It was too long, but I have to double check.

If it is too long then:
        $(foreach var,$(BUILD_MAKE_VARS),                                \
                         echo "$(var)=\"$($(var))\"" >>$(1).tmp;)
        \
would be OK (but with proper indentation)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel