Re: [Xen-devel] [PATCH 02/12] Config.mk: replace dependency to genpath with actual target

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-24 at 10:36 +0200, Olaf Hering wrote:
> genpath is a detail of buildmakevars2file. Replace the dependency to
> genpath with the actual buildmakevars2file target. This change by itself
> does not fix any bug. Upcoming changes will add dependencies to
> $(target), but no rule exist to create $(target).
> 
> With this change a rule for $(target) is added, which in turn depends on
> genpath. No change in behaviour is expected by this patch.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Wrong CC again.

> ---
>  Config.mk                     |  1 +
>  stubdom/Makefile              | 16 ++++++++--------
>  tools/hotplug/common/Makefile |  2 +-
>  tools/python/Makefile         |  2 +-
>  4 files changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index a26e964..eb3937c 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -173,6 +173,7 @@ BUILD_MAKE_VARS := SBINDIR BINDIR LIBEXEC LIBDIR SHAREDIR 
> PRIVATE_BINDIR \
>  buildmakevars2file = $(eval $(call buildmakevars2file-closure,$(1)))
>  define buildmakevars2file-closure
>      .PHONY: genpath
> +    $(1): genpath
>      genpath:

This seems like an odd construction. The genpath in the middle seems
redundant with you change. Do you not just want the result to be:
        $(1):
                rm -f $(1).tmp
                $(foreach, etc...

with no .PHONY-ness?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel