Re: [Xen-devel] [PATCH xen v2] xen: arm: fully implement multicall interface.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.04.14 at 13:39, <Ian.Campbell@xxxxxxxxxx> wrote:
> Actually, you mentioned preempt. Does calling domain_crash() cause
> hypercall_preempt_check to return true? In that case do_multicall
> already does the right thing. That would involve domain_crash either
> causing a softirq or an evtchn upcall, which I don't see it doing
> though. Perhaps just adding a d->is_shutting_down check alongside the
> preempt check in the multicall would do the trick.

Good point. And yes, a softirq is being raised implicitly:
domain_shutdown() calls vcpu_pause_nosync() for all the domain's
vCPU-s, which - via vcpu_sleep_nosync() - reaches the ->sleep()
callback of the individual schedulers, all of which raise the schedule
softirq if the subject vCPU is the one they're running on.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel