Re: [Xen-devel] [PATCH] xen: arm: arm64: Adding VFP save/restore support.

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 06/02/14 12:57, Ian Campbell wrote:
> On Thu, 2014-02-06 at 12:44 +0000, Julien Grall wrote:
> > > +                 :: "r" ((char *)(&v->arch.vfp.fpregs)): "memory");
> > I remember we had a discussion when I have implemented vfp context
> > switch for arm32 for the memory constraints
> > (http://lists.xen.org/archives/html/xen-devel/2013-06/msg00110.html).
> >
> > I think you should use "=Q" also here to avoid cloberring the whole memory.
> Yes, I forgot to say: I think getting something in now is the priority,
> which is why I committed it, but this should be tightened up, probably
> for 4.5 unless the difference is benchmarkable.
The fix is very simple (a matter of 2 lines changes). I would prefer to 
delay this patch for a couple of days and having a correct 
implementation from the beginning, so we will not forgot to change the 
code for Xen 4.5.
Moreover Pranav usually answer quickly :).

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel