Re: [Xen-devel] [PATCH 2/2 v2] xenstore: check F_SETFL fcntl invocation in setnonblock

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 2/2 v2] xenstore: check F_SETFL fcntl 
invocation in setnonblock"):
> On Mon, 2013-12-02 at 11:36 +0000, Ian Jackson wrote:
> > > + return fcntl(fd, F_SETFL, flags) != -1;
> > 
> > fcntl F_SETFL returns 0 on success and -1 or error.  But your
> > setnonblock is supposed to return 1 on success and 0 on error.
> 
> The trailing "!= -1" should make the the case, shouldn't it?

Oh, I didn't spot that.  How horrid.  I think I need to reject this on
style grounds...

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel