[Xen-devel] [PATCH 2/2 v2] xenstore: check F_SETFL fcntl invocation in setnonblock

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Matthew Daley writes ("[PATCH 2/2 v2] xenstore: check F_SETFL fcntl invocation 
in setnonblock"):
> ...and check the newly-added result of setnonblock itself where used.
...
> -static void setnonblock(int fd, int nonblock) {
> -     int esave = errno;
> +static bool setnonblock(int fd, int nonblock) {
>       int flags = fcntl(fd, F_GETFL);
>       if (flags == -1)
> -             goto out;
> +             return false;
>  
>       if (nonblock)
>               flags |= O_NONBLOCK;
>       else
>               flags &= ~O_NONBLOCK;
>  
> -     fcntl(fd, F_SETFL, flags);
> -out:
> -     errno = esave;
> +     return fcntl(fd, F_SETFL, flags) != -1;

fcntl F_SETFL returns 0 on success and -1 or error.  But your
setnonblock is supposed to return 1 on success and 0 on error.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel