[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC] improve the error message in "xl list --long"

Bamvor Jian Zhang writes ("[PATCH RFC] improve the error message in "xl list 
> there is a commit a76377f1 check the return value of
> libxl_read_file_contents in libxl_userdata_retrieve. but skip the ENOENT.
> it is almost three years before. i do not know the senario about that
> commit. it seems that it is not safe to simplely remove the ENOENT.

ENOENT means that there is no userdata associated with the relevant
domain and key.  This is not an error condition.

And it is deliberately possible to manipulate other toolstacks'
domains from xl.  You get to keep all the pieces.  If you want to make
this fail, then a safety catch might be OK but it should be in xl not
libxl and I think the manipulation should be allowed by default.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.