Re: [Xen-devel] [PATCH v2 1/4] xen/arm: Add macro MB

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 09/26/2013 03:32 PM, Ian Campbell wrote:
> On Thu, 2013-09-26 at 13:56 +0100, Julien Grall wrote:
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> ---
>>  xen/include/asm-arm/config.h |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>> index 604088e..2cea1ba 100644
>> --- a/xen/include/asm-arm/config.h
>> +++ b/xen/include/asm-arm/config.h
>> @@ -119,6 +119,7 @@
>>  #define BOOT_MISC_VIRT_START   _AT(vaddr_t,0x00600000)
>>  
>>  #define HYPERVISOR_VIRT_START  XEN_VIRT_START
>> +#define MB(_mb)     (_AC(_mb, UL) << 20)
> 
> Can you move the GB here too for consistency.
> 
> In fact it would be worth considering moving this to
> xen/include/xen/config.h and consolidating the x86 version too.

I will do.

I'm wondering, do we need to use ULL instead of UL in GB and MB?

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel