Re: [Xen-devel] [PATCH] libxl: remove qemu default devices for upstream qemu

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 26, 2013 at 04:43:09PM +0200, Fabio Fantoni wrote:
> Remove default devices created by qemu. Qemu will create only devices
> defined by xen, since the devices not defined by xen are not usable.
> Remove deleting of empty floppy no more needed with nodefault.
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> ---
>  tools/libxl/libxl_dm.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index d44857f..501b458 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -394,6 +394,11 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>      flexarray_append(dm_args, "-mon");
>      flexarray_append(dm_args, "chardev=libxl-cmd,mode=control");
>  
> +    /* Remove default devices created by qemu. Qemu will create only devices
> +    defined by xen, since the devices not defined by xen are not usable.
> +    Remove deleting of empty floppy no more needed with nodefault.*/

The comment style should be consistent with other multi-line comments.

Wei.

> +    flexarray_append(dm_args, "-nodefaults");
> +
>      if (b_info->type == LIBXL_DOMAIN_TYPE_PV) {
>          flexarray_append(dm_args, "-xen-attach");
>      }
> @@ -459,9 +464,6 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>      if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {
>          int ioemu_nics = 0;
>  
> -        /* Disable useless empty floppy drive */
> -        flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL);
> -
>          if (b_info->u.hvm.serial) {
>              flexarray_vappend(dm_args, "-serial", b_info->u.hvm.serial, 
> NULL);
>          }
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel