Re: [Xen-devel] [PATCH RFC v2 1/7] xen/vNUMA: vNUMA support for PV guests.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.09.13 at 11:31, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 13/09/2013 09:49, Elena Ufimtseva wrote:
>> +        if (
>> +        (d->vnuma.vdistance = xmalloc_bytes(
>> +                 sizeof(*d->vnuma.vdistance) * dist_size)) == NULL ||
> 
> sizeof in an operator not a function.  As you are not passing a type,
> the brackets are not required.

Actually, I'd request parentheses to be added if I saw a use
of sizeof() without them. I think we have quite few (hopefully
a majority) of uses similar to the one above in the tree.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel