Re: [Xen-devel] [PATCH 9/9] acpi/pmstat: fix check for empty name strings.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.13 at 14:15, Tim Deegan <tim@xxxxxxx> wrote:
> These 'name' strings are actually arrays in their structs.  So the
> address is never NULL: instead, we should check the first character to
> detect cases where the field wasn't initialized.
> 
> Coverity CID 1055633
> 
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
>  xen/drivers/acpi/pmstat.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c
> index f8a9c85..daac2da 100644
> --- a/xen/drivers/acpi/pmstat.c
> +++ b/xen/drivers/acpi/pmstat.c
> @@ -264,13 +264,13 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op 
> *op)
>      op->u.get_para.scaling_max_freq = policy->max;
>      op->u.get_para.scaling_min_freq = policy->min;
>  
> -    if ( cpufreq_driver->name )
> +    if ( cpufreq_driver->name[0] )
>          strlcpy(op->u.get_para.scaling_driver, 
>              cpufreq_driver->name, CPUFREQ_NAME_LEN);
>      else
>          strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN);
>  
> -    if ( policy->governor->name )
> +    if ( policy->governor->name[0] )
>          strlcpy(op->u.get_para.scaling_governor, 
>              policy->governor->name, CPUFREQ_NAME_LEN);
>      else
> -- 
> 1.7.10.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel