Re: [Xen-devel] [PATCH 8/9] ehci-dbgp: drop dead code.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.13 at 14:15, Tim Deegan <tim@xxxxxxx> wrote:
> We can only reach this spot by breaking out of the scan loop,
> so by construction ret > 0.
> 
> Coverity CID 1055259
> 
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

But this should really be patched in the original (Linux) first...

> ---
>  xen/drivers/char/ehci-dbgp.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
> index 0ac2dd9..b900d60 100644
> --- a/xen/drivers/char/ehci-dbgp.c
> +++ b/xen/drivers/char/ehci-dbgp.c
> @@ -946,11 +946,6 @@ try_again:
>          dbgp_printk("could not find attached debug device\n");
>          goto err;
>      }
> -    if ( ret < 0 )
> -    {
> -        dbgp_printk("attached device is not a debug device\n");
> -        goto err;
> -    }
>      dbgp->out.endpoint = dbgp_desc.bDebugOutEndpoint;
>      dbgp->in.endpoint = dbgp_desc.bDebugInEndpoint;
>  
> -- 
> 1.7.10.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel