Re: [Xen-devel] [PATCH 4/9] passthrough/amd: Shuffle declaration.

[Tim Deegan <tim@xxxxxxx>]

At 14:38 +0100 on 12 Sep (1378996715), Jan Beulich wrote:
> >>> On 12.09.13 at 14:15, Tim Deegan <tim@xxxxxxx> wrote:
> > Coverity's parser chokes on seeing __section() before the type.
> > 
> > Coverity CID 1087190
> > 
> > Signed-off-by: Tim Deegan <tim@xxxxxxx>
> > Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> > Cc: Jacob Shin <jacob.shin@xxxxxxx>
> > ---
> >  xen/drivers/passthrough/amd/iommu_acpi.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c 
> > b/xen/drivers/passthrough/amd/iommu_acpi.c
> > index 89b359c..2bfe61e 100644
> > --- a/xen/drivers/passthrough/amd/iommu_acpi.c
> > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c
> > @@ -633,7 +633,7 @@ static u16 __init parse_ivhd_device_extended_range(
> >      return dev_length;
> >  }
> >  
> > -static __initdata DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
> > +static DECLARE_BITMAP(__initdata ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
> 
> But putting it inside the DECLARE_BITMAP() doesn't seem that nice
> either. I think the second best option - if we need to play such
> games for Coverity in the first place -

Yes, I think the question of how much we're willing to accommodate
Coverity in our source code needs to be discussed.  On that subject I
have an RFC patch that introduces some annotation...

> would be to put this at the end.

Yes, that sounds better.  Thus?

index 89b359c..e967eba 100644
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -633,7 +633,7 @@ static u16 __init parse_ivhd_device_extended_range(
     return dev_length;
 }
 
-static __initdata DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
+static DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf)) __initdata;
 
 static void __init parse_ivrs_ioapic(char *str)
 {

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel