Re: [Xen-devel] [PATCH 1/1 V3] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/09/13 13:59, Jan Beulich wrote:
>>>> On 10.09.13 at 14:52, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 10/09/13 13:47, Jan Beulich wrote:
>>>>>> On 09.09.13 at 17:52, <suravee.suthikulpanit@xxxxxxx> wrote:
>>>> +        {
>>>> +            AMD_IOMMU_DEBUG("Skipping host bridge %04x:%02x:%02x.%u (type 
>>>> %x)\n",
>>>> +                        pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), 
>>>> PCI_FUNC(bdf),
>>>> +                        pdev->type);
>>> Saying "host bridge" _and_ being in a conditional only allowing host
>>> bridges in makes printing the type redundant.
>> I specifically asked for "host bridge" here for the benefit of people
>> just reading the boot dmesg.
> And I'm not arguing about its usefulness. I'm asking for the printing
> of type to be removed.
>
> Jan
>

Oops sorry - yes.  I mis-infered your meaning.  I agree that the (type
%x) is superfluous

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel