Re: [Xen-devel] [PATCH V1 21/29] xen/arm: Create a fake GIC node in dom0 device tree

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-09-10 at 11:49 +0100, Julien Grall wrote:
> On 09/09/2013 12:49 PM, Ian Campbell wrote:
> > On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote:
> >> @@ -514,6 +587,7 @@ static int handle_node(struct domain *d, struct 
> >> kernel_info *kinfo,
> >>          DT_MATCH_COMPATIBLE("xen,multiboot-module"),
> >>          DT_MATCH_COMPATIBLE("arm,psci"),
> >>          DT_MATCH_PATH("/cpus"),
> >> +        DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"),
> > 
> > This will need changing as we change the list in gic.c.
> > 
> > Is there some way we can make this generic by using
> > dt_interrupt_controller->compatible?
> 
> compatible is a list of zeroed string. How about a define in gic.h?
> 
> #define GIC_COMPATIBLE                   \
>   DT_MATCH_PATH("arm,cortex-a15-gic)
> 
> So we can use in the different place.

Sure. DT_GIC_COMPATIBLE perhaps? or DT_MATCH_GIC?

> 
> > Otherwise I think we either need a comment at both locations or way to
> > share the lists.
> > 
> > Ian.
> > 
> >>          { /* sentinel */ },
> >>      };
> >>      const struct dt_device_node *child;
> > 
> > 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel