Re: [Xen-devel] [PATCH RFC 2/2] AMD IOMMU: allow command line overrides for broken IVRS tables

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/08/13 14:55, Jan Beulich wrote:
>>>> On 27.08.13 at 15:32, Sander Eikelenboom <linux@xxxxxxxxxxxxxx> wrote:
>> Hmmm even with:
>>
>> static void __init parse_ivrs_ioapic(char *str)
>> {
>>     const char *s = str;
>>     unsigned long id;
>>     unsigned int seg, bus, dev, func;
>>
>>     AMD_IOMMU_DEBUG(" will be parsing things: %s" , str);
>>
>>     ASSERT(*s == '[');
>>     id = simple_strtoul(s + 1, &s, 0);
>>     if ( id >= ARRAY_SIZE(ioapic_sbdf) || *s != ']' || *++s != '=' ){
>>         AMD_IOMMU_DEBUG("bailing out here %lu" , id);
>>
>>         return;
>>     }
>>     s = parse_pci(s + 1, &seg, &bus, &dev, &func);
>>     if ( !s || *s ){
>>
>>             AMD_IOMMU_DEBUG(" Something went wrong parsing things: %s" , 
>> str);
>>             return;
>>     }
>>     AMD_IOMMU_DEBUG("parsed things: %lu, %d, %d , %d" ,id, bus, dev, func);
>>
>>     ioapic_sbdf[id].bdf = PCI_BDF(bus, dev, func);
>>     ioapic_sbdf[id].seg = seg;
>>     __set_bit(id, ioapic_cmdline);
>> }
>> custom_param("ivrs_ioapic[", parse_ivrs_ioapic);
>>
>> I don't see anything ...
> That's not surprising - command line parsing happens before any
> consoles get set up.
>
> Jan
>

If you have a serial console enabled, then you will see those prints,
but they will not show up in `xl dmesg`

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel